Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: set tcp_nodelay == true by default and explicit APIs #1263

Merged
merged 7 commits into from
Dec 11, 2023
Merged

refactor: set tcp_nodelay == true by default and explicit APIs #1263

merged 7 commits into from
Dec 11, 2023

Conversation

niklasad1
Copy link
Member

Close #1262

@niklasad1 niklasad1 requested a review from a team as a code owner December 11, 2023 10:23
@niklasad1 niklasad1 changed the title feat: add explicit API set_tcp_nodelay feat: add explicit API to set tcp_nodelay Dec 11, 2023
lexnv
lexnv approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@niklasad1 niklasad1 changed the title feat: add explicit API to set tcp_nodelay refactor: set tcp_nodelay = true by default and explicit API Dec 11, 2023
@niklasad1 niklasad1 changed the title refactor: set tcp_nodelay = true by default and explicit API refactor: set tcp_nodelay = true by default Dec 11, 2023
@niklasad1 niklasad1 changed the title refactor: set tcp_nodelay = true by default refactor: set tcp_nodelay == true by default Dec 11, 2023
@niklasad1 niklasad1 changed the title refactor: set tcp_nodelay == true by default refactor: set tcp_nodelay == true by default and explicit APIs Dec 11, 2023
@niklasad1 niklasad1 merged commit 8466e12 into master Dec 11, 2023
11 checks passed
@niklasad1 niklasad1 deleted the na-fix-1262 branch December 11, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding explicit capability to set TCP_NODELAY on client
2 participants
@niklasad1 @lexnv